Reland: Split histograms for HTTP error code and status
Original description:
> This CL adds more specific variants of the following histograms:
>
> * PrivacySandbox.AggregationService.ReportSender.HttpResponseOrNetErrorCode
> * PrivacySandbox.AggregationService.ReportSender.Status
>
> The new histograms break out "Status" and "HttpResponseOrNetErrorCode"
> information based on whether the request was not scheduled, or was
> originally scheduled for future delivery after a reduced delay or full
> delay.
>
> ```
> $ ./tools/metrics/histograms/print_histogram_names.py --diff origin/main
> 6 histograms added:
> PrivacySandbox.AggregationService.ReportSender.ScheduledWithFullDelay.HttpResponseOrNetErrorCode
> PrivacySandbox.AggregationService.ReportSender.ScheduledWithFullDelay.Status
> PrivacySandbox.AggregationService.ReportSender.ScheduledWithReducedDelay.HttpResponseOrNetErrorCode
> PrivacySandbox.AggregationService.ReportSender.ScheduledWithReducedDelay.Status
> PrivacySandbox.AggregationService.ReportSender.Unscheduled.HttpResponseOrNetErrorCode
> PrivacySandbox.AggregationService.ReportSender.Unscheduled.Status
> 0 histograms removed:
> ```
>
> Initially, I thought I'd replace the histograms with their more specific
> variants. However, I chose to keep the original histograms to avoid any
> monitoring disruptions. The "Status" histogram is a critical system
> health metric, so it's probably not a good idea to delete it without
> having a successor in place.
>
> Bug: 325449807
In <https://crrev.com/c/5598362>, I introduced two new death tests that
used `EXPECT_DEATH_IF_SUPPORTED`. These passed CQ, but started failing
on linux-chromeos-chrome after the CL was merged. It turns out that
under some GN args, the `CHECK` macro will discard log strings rather
than streaming them.
Patchset 1 is just a cherrypick of the original CL. I verified that it
fails on the linux-chromeos-chrome as described in issue 352185227.
This reland replaces the gtest-provided `EXPECT_DEATH_IF_SUPPORTED` with
the //base wrapper `EXPECT_CHECK_DEATH_WITH`, which accounts for whether
the `CHECK` macro will stream or discard its messages.
Bug: 325449807, 352185227
Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Change-Id: I1b1935c206ddb3b258b3229d888c3f614b3627e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5688555
Reviewed-by: Alex Turner <alexmt@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Nan Lin <linnan@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1326362}
NOKEYCHECK=True
GitOrigin-RevId: ed224e2bb688981e5517544073ce200b0f7f6160
1 file changed
