| commit | 3ae3b01ad157befc41d5afeb727a804e883efc1b | [log] [tgz] |
|---|---|---|
| author | Muyao Xu <muyaoxu@google.com> | Thu May 16 23:21:49 2024 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu May 16 23:24:17 2024 |
| tree | 2a8c65f93e38bb5e8cb0f10a341a77de8587d0a5 | |
| parent | 2b523224efaa7628ed1d69fc63a70ebf82b748e0 [diff] |
Revert "HTML Mode Removal: Exposes HTML id as a string attribute" This reverts commit e4febc9a49dae73e2acd7a17d4c8fd96c960ec4f. Reason for revert: Causing Linux Builder failure: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-presubmit/15117/overview third_party/closure_compiler/externs/automation.js doesn't contain a copyright header. Original change's description: > HTML Mode Removal: Exposes HTML id as a string attribute > > There are a bunch of places where HTML attributes are being > retrieved just to get the node's id. > We eliminate the need to have HTML accessibility mode on by > exposing the HTML id as part of the string attributes. > > Design doc: > https://docs.google.com/document/d/1M3sivfoPd0PpbB1G802XEa-2MSA46TaVcCX7q0Npx_o/edit?usp=sharing > > R=aleventhal@chromium.org > > AX-Relnotes: n/a. > Change-Id: I262c0b1cdb9916c5c6bdebb01707e333096e59bf > Bug: b/336844380 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5480607 > Auto-Submit: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1302182} Bug: b/336844380 Change-Id: I840bc13b46993aa40c8623518e75cd3d13bd4526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5546305 Auto-Submit: Muyao Xu <muyaoxu@google.com> Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by: Muyao Xu <muyaoxu@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Muyao Xu <muyaoxu@google.com> Cr-Commit-Position: refs/heads/main@{#1302301} NOKEYCHECK=True GitOrigin-RevId: c5a17bd711b0aeb5b10e5a4daae9499a9cdbbe60