Remove OSCertHandle typedefs, use smart pointers for CRYPTO_BUFFER ownership.
Also renames / removes some X509Certificate methods to make more sense
in the use_byte_certs world:
os_cert_handle() -> cert_buffer()
GetIntermediateCertificates() -> intermediate_buffers()
CreateFromHandle() -> CreateFromBuffer()
CreateOSCertHandleFromBytes() -> CreateCertBufferFromBytes()
CreateOSCertHandlesFromBytes() -> CreateCertBuffersFromBytes()
GetDEREncoded() -> x509_util::CryptoBufferAsStringPiece()
IsSameOSCert() -> x509_util::CryptoBufferEqual()
DupOSCertHandle() -> x509_util::DupCryptoBuffer()
FreeOSCertHandle() -> N/A (everything uses bssl::UniquePtr<CRYPTO_BUFFER>)
Bug: 769549
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5d94158ea5e7ba5e9e3b9f2f5e76221564c9683b
Reviewed-on: https://chromium-review.googlesource.com/775540
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522269}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a4193270b51780e7f1146766cfcc232ea2a971fe1 file changed
