commit | d6370968a8ca61ddf4f780bcd9c90809389b60a0 | [log] [tgz] |
---|---|---|
author | 余佳 <yujia.1019@bytedance.com> | Fri Jul 12 01:56:05 2024 |
committer | Copybara-Service <copybara-worker@google.com> | Fri Jul 12 01:58:43 2024 |
tree | 0f909b51c0831e52dfee10c3f78e0bd812153b07 | |
parent | 20f522296062cf48fdb0e5c61b08baba88bd9885 [diff] |
Fix a crash in onAvailable() network callbacks ConnectivityManagerDelegate.getNetworkCapabilities() is non-reentrant, because it may crash and retry. So in MyNetworkCallback.onAvailable(), the `capabilities` variation may be inited as nullptr, but passes MyNetworkCallback.ignoreConnectedNetwork() check. MyNetworkCallback.ignoreConnectedInaccessibleVpn() doesn't need to invoke ConnectivityManagerDelegate.getNetworkCapabilities() again. Bug: 350362785 Change-Id: Ia22cacab3669e320510dfc06c06af11d495b85f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5670233 Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Auto-Submit: 余佳 <yujia.1019@bytedance.com> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1326510} NOKEYCHECK=True GitOrigin-RevId: 7f4cde9fc32b9c8399565767ee45bb1915ec7b1a
This directory contains the code behind Chrome's networking stack. It is documented here.