Google Git
Sign in
chromium / chromium / src / net / cdaa1b803d653a04fa2352e332eb7a573c227168
commitcdaa1b803d653a04fa2352e332eb7a573c227168[log] [tgz]
authorDaniel Cheng <dcheng@chromium.org>Fri Jul 12 06:45:34 2024
committerCopybara-Service <copybara-worker@google.com>Fri Jul 12 06:47:32 2024
tree3eb4b34ad9e0d1bcddfa3b156e8c59792cb505b4
parentd6370968a8ca61ddf4f780bcd9c90809389b60a0 [diff]
[MSan] Fix use-after-dtor errors in TestNetworkQualityEstimator

The estimator embeds an EmbeddedTestServer; destroying the test server
waits for shutdown to complete on the IO thread. While waiting, the
estimator may receive posted tasks with new observations and try to use
other fields of the TestNetworkQualityEsimator. Destroying
EmbeddedTestServer prevents these observation callbacks from using
already-destroyed fields.

Bug: 40222690
Change-Id: Id0589436ef7a7c47d2ac7c44cc266dd3938381a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5690686
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1326577}
NOKEYCHECK=True
GitOrigin-RevId: 813a3a3ee953c87c2346657db5d6103d91a5a134
2 files changed
tree: 3eb4b34ad9e0d1bcddfa3b156e8c59792cb505b4
  1. android/
  2. base/
  3. cert/
  4. cert_net/
  5. cookies/
  6. data/
  7. device_bound_sessions/
  8. disk_cache/
  9. dns/
  10. docs/
  11. extras/
  12. filter/
  13. first_party_sets/
  14. http/
  15. log/
  16. network_error_logging/
  17. nqe/
  18. ntlm/
  19. proxy_resolution/
  20. quic/
  21. reporting/
  22. server/
  23. shared_dictionary/
  24. socket/
  25. spdy/
  26. ssl/
  27. storage_access_api/
  28. test/
  29. third_party/
  30. tools/
  31. traffic_annotation/
  32. url_request/
  33. websockets/
  34. BUILD.gn
  35. COMMON_METADATA
  36. DEPS
  37. DIR_METADATA
  38. features.gni
  39. OWNERS
  40. PRESUBMIT.py
  41. README.md
README.md

Chrome Networking Stack

This directory contains the code behind Chrome's networking stack. It is documented here.