Reland "[tracing] Remove special handling of task execution and log events"
This reverts commit 989724c3091f42ea9b2cff98980ae2791d02b993.
Reason for revert:
Fixing test failures. The msan failures were due to hash operator trying
to hash uninitialized padded bytes of the struct. Fix the struct to not
have any padding.
Original change's description:
> Revert "[tracing] Remove special handling of task execution and log events"
>
> This reverts commit f79b1513420778734014302fedddd83e3568efc8.
>
> Reason for revert: Breaks WebKit Linux MSAN
>
> The following tests started failing since this landed:
>
> * http/tests/devtools/tracing.js
> * http/tests/devtools/tracing/decode-resize.js
> * http/tests/devtools/tracing/timeline-paint/update-layer-tree.js
> * http/tests/devtools/tracing/timeline-style/parse-author-style-sheet.js
> * http/tests/devtools/tracing/tracing-record-input-events.js
> * http/tests/devtools/tracing/user-timing.js
> * http/tests/devtools/tracing/worker-events.js
> * http/tests/devtools/tracing/worker-js-frames.js
> * inspector-protocol/sessions/tracing-start.js
> * inspector-protocol/timeline/tracing-proto-format.js
>
> First run that failed, also the run where the CL landed:
> https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/7830
>
> Original change's description:
> > [tracing] Remove special handling of task execution and log events
> >
> > The task execution and log events are handled specially for writing
> > proto arguments because we did not have the support for typed events in
> > base and interning support for the event macros. Now these events can
> > use the new client library API.
> > The events have to be migrated together because the source location
> > interning index is common for all events in the API and does not
> > account for the special handling in event sink.
> >
> > BUG=1136635
> > TBR=chirantan@chromium.org
> >
> > Change-Id: I381e8c90e49c3fbd9ce4d8fb2e9db3d166b9b06d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462636
> > Reviewed-by: ssid <ssid@chromium.org>
> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> > Reviewed-by: danakj <danakj@chromium.org>
> > Reviewed-by: Erik Chen <erikchen@chromium.org>
> > Reviewed-by: Eric Seckler <eseckler@chromium.org>
> > Commit-Queue: ssid <ssid@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#815911}
>
> TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,eseckler@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1136635
> Change-Id: I7a84356400bbdcae3144fd65afdcab7a4407dcd9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462895
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#816069}
TBR=danakj@chromium.org,chirantan@chromium.org,erikchen@chromium.org,skyostil@chromium.org,ssid@chromium.org,ortuno@chromium.org,eseckler@chromium.org
# Not skipping CQ checks because this is a reland.
Bug: 1136635
Change-Id: Ia659185ebeb265dc47ff6c2ef47bd9d8cc43dd65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466507
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816620}
GitOrigin-RevId: 3b99bb2487ca1280b2f13e3a1dc8cf6a94a9f932
1 file changed
