commit | 5b9bb7b13a55accc107b181be97b281e7ff8023c | [log] [tgz] |
---|---|---|
author | Arthur Sonzogni <arthursonzogni@chromium.org> | Tue May 28 09:04:54 2024 |
committer | Copybara-Service <copybara-worker@google.com> | Tue May 28 09:09:59 2024 |
tree | bae8b6c9022509a20b905f61ae9be2f14bb10472 | |
parent | 7a54677010dfd89a5939e5572bd65871956a027b [diff] |
PA: Remove the dependency on chromium's enable_arc config. This invert the dependency. Embedders like chromium, dawn, skia, etc... needs to provide the config they used by default, so that it can be removed. Bug: chromium:41481467 Change-Id: Iaf788ed45be8af07159d7a11bf9c244e765848e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5573570 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1306657} NOKEYCHECK=True GitOrigin-RevId: dd97ff11df4d1ece656678f9dc3842b0c1576a1e
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/41240413): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.