commit a45e7f0809b149158e29b9f69a76fd0b375b4e6a
author Fumitoshi Ukai <ukai@google.com> Thu Jul 11 01:54:40 2024
committer Copybara-Service <copybara-worker@google.com> Thu Jul 11 02:00:33 2024
tree 46f92f3b0c81e4aee8e084735855f85863c75a8a
parent 5645f5086487ddc7fcba084225a300486e1694aa

Reland "Reland "siso: pass ios_sdk_path and mac_sdk_path from gn""

This reverts commit b29b6ac54872c49766b27be60618eea76d2e1cbd.

Reason for revert:
Create filegroup only if use_remoteexec=true.

If use_remoteexec is not true, these sdks dirs would not be
under exec root, which causes failure in creating filegroup.
These filegroups are used for remote execution, so no need
to create them if use_remoteexec is not true.

Original change's description:
> Revert "Reland "siso: pass ios_sdk_path and mac_sdk_path from gn""
>
> This reverts commit 8219b5dc35a5df684e138ffbdba8b772a66ae460.
>
> Reason for revert: This breaks our ios official builders (b/352216756)
>
> Original change's description:
> > Reland "siso: pass ios_sdk_path and mac_sdk_path from gn"
> >
> > This reverts commit 95a4d15d9708dcf11a1915a6f082d55616d3528f.
> >
> > Reason for revert: siso v0.2.7 was rolled out
> >
> > test with siso latest
> > https://chromium.googlesource.com/infra/infra/+/375a44b94c35de2a01d0eeef2fdcf2e8451e2664
> >
> > $ led get-builder chromium/build/ios-build-perf-developer | led edit-gerrit-cl https://chromium-review.googlesource.com/c/chromium/src/+/5674203 | led launch
> > [W 2024-07-03 16:24:56] waiting for JobDefinition on stdin...
> > [I 2024-07-03 16:24:56] Launching the led job as a real build
> > [I 2024-07-03 16:24:57] LUCI UI: https://ci.chromium.org/b/8743451912140978017
> >
> >
> > Original change's description:
> > > Revert "siso: pass ios_sdk_path and mac_sdk_path from gn"
> > >
> > > This reverts commit e71705c950a57a26a947adf5343326a77a0f0502.
> > >
> > > Reason for revert:
> > > https://ci.chromium.org/ui/p/chromium/builders/build/ios-build-perf-developer/2502/overview
> > >
> > > fail in Build chrome with remote cache with Siso in native mode
> > >
> > > Original change's description:
> > > > siso: pass ios_sdk_path and mac_sdk_path from gn
> > > >
> > > > Bug: b/323091468
> > > > Change-Id: Ibddb9833bbb03a1ff773a87d5f06bb8efd29fd26
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5666079
> > > > Reviewed-by: Junji Watanabe <jwata@google.com>
> > > > Reviewed-by: Richard Wang <richardwa@google.com>
> > > > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> > > > Cr-Commit-Position: refs/heads/main@{#1321991}
> > >
> > > Bug: b/323091468
> > > Change-Id: I231269b4b11b298ab05bd69ff817c617875598d9
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5672144
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> > > Cr-Commit-Position: refs/heads/main@{#1322069}
> >
> > Bug: b/323091468
> > Change-Id: Ida4bcd4a0edf8b21e92e24e65b064e95d0d81ce2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5674203
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Reviewed-by: Junji Watanabe <jwata@google.com>
> > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1324631}
>
> Bug: b/323091468
> Change-Id: If04104df94f07fb9b44491d6262ec6c5a3a4130a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5691691
> Commit-Queue: Vincent Boisselle <vincb@google.com>
> Reviewed-by: Philipp Wollermann <philwo@google.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1325502}

Bug: 352216756, 323091468
Change-Id: I0d6fd8f6e80872bdc0cde27bcc009111765fe8a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5693358
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Cr-Commit-Position: refs/heads/main@{#1325876}
NOKEYCHECK=True
GitOrigin-RevId: c1dfdf20cc8f4588ee28d3ae4a7dc56c97f85b53