Revert of Roll breakpad 37070c5..eaedc45 (patchset #1 id:1 of https://codereview.chromium.org/2718173002/ )
Reason for revert:
Failing for chrome_child.dll on x86 builds only. crbug.com/696911.
Original issue's description:
> Roll breakpad 37070c5..eaedc45
>
> eaedc45 Improve stack sanitization unittests.
> 0ca6751 Handle ntdll only emitting PUBLIC at func entry
> c7e826f Make stack sanitization elide pointers to non-executable mappings.
> 918f3dc Use the correct PC when determining whether to skip storing a stack.
> f9d3ab8 minidump: mark Read as override in derived classes
> 3ff7ca4 Fix compile errors arising from compiling breakpad with clang.
> 3996c1b libdisasm: add upstream/license details
> 603f8b6 There is no need to use the main queue just for perform selector.
> e6123b1 Appveyor CI for Windows MSVS build
> 376784d processor: drop set-but-unused variable
> 122d65d macho_reader_unittest: use EXPECT_FALSE
> 093fab2 windows: fix build on pre-Win10 systems
> 620e0fb windows: update gtest/gmock paths
> fc92bb3 fix write() unused-result warning
> d5f233d Fixed leak of unloaded module lists.
>
> Previous reverted attempt was
> https://codereview.chromium.org/2719553002. This rolls in the same code.
> However, this time symupload was instead built with VS2013. I confirmed
> the link line included:
>
> /LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 12.0\/DIA SDK/lib"
>
> and:
>
> c:\src\cr\src\breakpad>dumpbin /headers symupload.exe | grep linker
> 12.00 linker version
>
> This is expected to help because the suspicion is that only msdia120.dll
> is registered on official bots, not msdia140.dll.
>
> R=mark@chromium.org
> BUG=678874,696257,696671
>
> Review-Url: https://codereview.chromium.org/2718173002
> Cr-Commit-Position: refs/heads/master@{#453325}
> Committed: https://chromium.googlesource.com/chromium/src/+/5f3ea1407ad98cdb9d8418a52d3dbeff7ec5033e
TBR=mark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=678874,696257,696671
Review-Url: https://codereview.chromium.org/2726633002
Cr-Original-Commit-Position: refs/heads/master@{#453647}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8af45a18bab6cf4f1dc16a92a229dfa2b7e81dd1
1 file changed
