commit | cf98e540d06dcec3eab665a255d086e4428561d2 | [log] [tgz] |
---|---|---|
author | Dirk Pranke <dpranke@google.com> | Sat Aug 03 04:01:14 2024 |
committer | Copybara-Service <copybara-worker@google.com> | Sat Aug 03 04:07:06 2024 |
tree | 590a9af660ca613cf1ec5c3a0a30e0b133ce1070 | |
parent | f02eebc482ea48c2336d61126d665dbc48fd3dd8 [diff] |
Revert "Reland "base_profiler_test_support_library: Don't link libc++ and libc++abi"" This reverts commit 28090b0aa1960957082d613f3181fa960fa6b4ab. Reason for revert: Broke the win-asan build again, this time differently: https://ci.chromium.org/ui/b/8740664034807324977 . I'm not sure how this got through the CQ Original change's description: > Reland "base_profiler_test_support_library: Don't link libc++ and libc++abi" > > This is a reland of commit 75f0ff2f430f3dd04a4693f43baad2b9633e62ab > > Original change's description: > > base_profiler_test_support_library: Don't link libc++ and libc++abi > > > > It's not necessary and makes base_profiler_test_support_library.so build > > faster. > > > > Moreover, a recent change to libc++abi makes it use `thread_local`. > > With that, base_profiler_test_support_library would be a binary that > > uses thread-local storage, which at least on macOS prevents dlclose() > > from unloading base_profiler_test_support_library.so, causing > > StackSamplingProfilerTest.UnloadedLibrary to fail. > > See bug for more details. > > > > This fixes that and unblocks rolling libc++abi. > > > > Change base_profiler_reparsing_test_support_library as well. > > that's not necessary for anything as far as I know, but it's nice > > if that target also builds faster, and if things are consistent. > > > > Bug: 351867703 > > Change-Id: I0177ef1fd3cdfe4457bab50aa9f8921e82af2bca > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5759749 > > Auto-Submit: Nico Weber <thakis@chromium.org> > > Reviewed-by: Arthur Eubanks <aeubanks@google.com> > > Commit-Queue: Arthur Eubanks <aeubanks@google.com> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1336769} > > Bug: 351867703 > Cq-Include-Trybots: luci.chromium.try:win-asan-rel > Change-Id: I59edfc781e521bbe38d3083bc212d3c870607e3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5760770 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Erik Staab <estaab@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Erik Staab <estaab@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1336903} Bug: 351867703 Change-Id: I951bab9ac3a7f7c096cc02078e7ed822988974da Cq-Include-Trybots: luci.chromium.try:win-asan-rel No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5760936 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#1336919} NOKEYCHECK=True GitOrigin-RevId: 027e67ac8ed42fab8416d2cb55dfba32be3fa633
Contains a written down set of principles and other information on //base. Please add to it!
Chromium is a very mature project. Most things that are generally useful are already here and things not here aren't generally useful.
The bar for adding stuff to base is that it must have demonstrated wide applicability. Prefer to add things closer to where they're used (i.e. “not base”), and pull into base only when needed. In a project our size, sometimes even duplication is OK and inevitable.
Adding a new logging macro DPVELOG_NE
is not more clear than just writing the stuff you want to log in a regular logging statement, even if it makes your calling code longer. Just add it to your own code.
If the code in question does not need to be used inside base, but will have multiple consumers across the codebase, consider placing it in a new directory under components/ instead.
base is written for the Chromium project and is not intended to be used outside it. Using base outside of src.git is explicitly not supported, and base makes no guarantees about API (or even ABI) stability (like all other code in Chromium). New code that depends on base/ must be in src.git. Code that's not in src.git but pulled in through DEPS (for example, v8) cannot use base.
Owners are added when a contributor has shown the above qualifications and when they express interest. There isn't an upper bound on the number of OWNERS.
Since the primitives provided by //base are used very widely, it is important to ensure they scale to the necessary workloads and perform well under all supported platforms. The base_perftests
target is a suite of synthetic microbenchmarks that measure performance in various scenarios:
thread_local
, the implementation in //base, the POSIX/WinAPI directly)Regressions in these benchmarks can generally by caused by 1) operating system changes, 2) compiler version or flag changes or 3) changes in //base code itself.