shill: Cleanup metrics logic tracking online state
1. was_online_ is meant to leave notes for future invocations
of NotifyDefaultServiceChanged, and meant to be used along with
last_default_technology_. Change it to was_last_online to make the
connection more obvious.
2. "Ignore changes that are not online/offline transitions" is
hard to read. This should be "only consider transitions b/w
online and offline". Make that snippet more readable.
BUG=chromium:832145
TEST=shill unit-tests pass
Change-Id: Iaeef47e12a2188563d0fe799436304993631a37e
Signed-off-by: Kirtika Ruchandani <kirtika@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1167888
Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org>
Tested-by: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
2 files changed