Differential D214261

Bug 1903329 - Update non262 TypedArray tests; r=nbp!
ClosedPublic
Actions

Authored by dminor on Jun 19 2024, 1:36 PM.

Details

Reviewers
nbp
Commits
rMOZILLACENTRALfd17e226fbe8: Bug 1903329 - Update non262 TypedArray tests; r=nbp
rMOZILLACENTRALe17166677489: Bug 1903329 - Update non262 TypedArray tests; r=nbp
Bugzilla Bug ID
1903329

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dminor created this revision.Jun 19 2024, 1:36 PM
Herald added a project: secure-revision. · View Herald TranscriptJun 19 2024, 1:36 PM
Harbormaster completed remote builds in B674196: Diff 878890.Jun 19 2024, 1:36 PM
phab-bot published this revision for review.Jun 19 2024, 1:37 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
nbp accepted this revision.Jun 19 2024, 3:25 PM
nbp added inline comments.
js/src/tests/non262/TypedArray/sort-negative-nan.js
53–60

comment-nit: Quiet and signaling bits/comments are swapped, if I do not make any mistakes.

This revision is now accepted and ready to land.Jun 19 2024, 3:25 PM
Herald added a project: needs-testing-tag. · View Herald TranscriptJun 19 2024, 3:25 PM

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

dminor marked an inline comment as done.Thu, Jun 20, 1:29 PM
dminor added inline comments.
js/src/tests/non262/TypedArray/sort-negative-nan.js
53–60

Thanks for catching this!

dminor updated this revision to Diff 879624.Thu, Jun 20, 1:34 PM
dminor edited the summary of this revision. (Show Details)
dminor marked an inline comment as done.
Harbormaster completed remote builds in B674767: Diff 879624.Thu, Jun 20, 1:34 PM
Closed by commit rMOZILLACENTRALe17166677489: Bug 1903329 - Update non262 TypedArray tests; r=nbp (authored by dminor). · Explain WhyThu, Jun 20, 2:16 PM
This revision was automatically updated to reflect the committed changes.
dminor added a commit: rMOZILLACENTRALe17166677489: Bug 1903329 - Update non262 TypedArray tests; r=nbp.
sstanca reopened this revision.Thu, Jun 20, 3:43 PM
This revision is now accepted and ready to land.Thu, Jun 20, 3:43 PM
sstanca added a reverting change: rMOZILLACENTRAL47063b482215: Backed out 3 changesets (bug 1903329) for causing wpt failures on Android..Thu, Jun 20, 3:43 PM
dminor updated this revision to Diff 880472.Fri, Jun 21, 3:55 PM
Harbormaster completed remote builds in B675374: Diff 880472.Fri, Jun 21, 3:55 PM
dminor added a child revision: D214596: Bug 1903329 - Enable Float16 in JSStructuredCloneReader::readTypedArray; r=nbp!.Fri, Jun 21, 3:55 PM
Closed by commit rMOZILLACENTRALfd17e226fbe8: Bug 1903329 - Update non262 TypedArray tests; r=nbp (authored by dminor). · Explain WhySun, Jun 23, 11:49 PM
This revision was automatically updated to reflect the committed changes.
dminor added a commit: rMOZILLACENTRALfd17e226fbe8: Bug 1903329 - Update non262 TypedArray tests; r=nbp.

Revision Contents
Changeset List

PathSize
js/
src/
tests/
non262/
TypedArray/
10 lines
72 lines
4 lines
4 lines

Diff 880909

View Options

js/src/tests/non262/TypedArray/indexOf-and-lastIndexOf.js

Loading...
View Options

js/src/tests/non262/TypedArray/sort-negative-nan.js

Loading...
View Options

js/src/tests/non262/TypedArray/sort_small.js

Loading...
View Options

js/src/tests/non262/TypedArray/toString.js

Loading...
Privacy · Cookies · Legal